Codecov Report

❗ No coverage uploaded for pull request base (main@01555c2). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 61b0253 differs from pull request most recent head e1ef3c9. Consider uploading reports for the commit e1ef3c9 to get more accurate results

@@           Coverage Diff           @@
##             main   #19959   +/-   ##
=======================================
  Coverage        ?   36.51%           
  Complexity      ?     1634           
=======================================
  Files           ?      543           
  Lines           ?    21214           
  Branches        ?     3176           
=======================================
  Hits            ?     7746           
  Misses          ?    12590           
  Partials        ?      878           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01555c2...e1ef3c9. Read the comment docs.

Request for data collection review

1. What questions will you answer with this data?

   • This data will tell us if a user changes the tab tray view when the (new) default is grid view.

2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

   • Yes, this gives us an understanding of user experience if our new default is the right one and we increase in usage.

3. What alternative methods did you consider to answer these questions? Why were they not sufficient?

   • No alternative is available to answer this question.

4. Can current instrumentation answer these questions?

   • No, we have tab_view_setting that exists, but this can incorrectly skew our data for users that have not changed the default settings and will see the new default.

5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

6. How long will this data be collected? Choose one of the following:

   • I want this data to be collected for 1 year initially (ending on May 10, 2022), with the option to renew at that point.


7. What populations will you measure?

   • No filters - all locales, channels, etc.

8. If this data collection is default on, what is the opt-out mechanism for users?

   • Default Glean SDK opt-out mechanism.

9. Please provide a general description of how you will analyze this data.

   • When we see that our new default increases in usage, and users are not switching away from the new default.

10. Where do you intend to share the results of your analysis?

    • Internally in the Fenix teams.

11. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?

    • No third-party tool will use this data.

We have a similar telemetry for this in "tab_view_setting". I am not quite sure if it's worthwhile to collect the "change" since we already collect a metrics ping about what the tab view is set to everyday. You will also want to consult with DS in #data-help.

Of course, I see you talk about "tab_view_setting" after I wrote all of the above.

Request for data collection review

1. What questions will you answer with this data?
   
   * This data will tell us if a user changes the tab tray view when the (new) default is grid view.

2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
   
   * Yes, this gives us an understanding of user experience if our new default is the right one and we increase in usage.

3. What alternative methods did you consider to answer these questions? Why were they not sufficient?
   
   * No alternative is available to answer this question.

4. Can current instrumentation answer these questions?
   
   * No, we have `tab_view_setting` that exists, but this can incorrectly skew our data for users that have not changed the default settings and will see the new default.

5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

Measurement Description Data Collection Category Tracking Bug #
Tab view setting is list or grid category 2 - Interaction data #19956

1. How long will this data be collected? Choose one of the following:
   
   * I want this data to be collected for 1 year initially (ending on May 10, 2022), with the option to renew at that point.

2. What populations will you measure?
   
   * No filters - all locales, channels, etc.

3. If this data collection is default on, what is the opt-out mechanism for users?
   
   * Default Glean SDK opt-out mechanism.

4. Please provide a general description of how you will analyze this data.
   
   * When we see that our new default increases in usage, and users are not switching away from the new default.

5. Where do you intend to share the results of your analysis?
   
   * Internally in the Fenix teams.

6. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
   
   * No third-party tool will use this data.

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the "Send Usage Data" toggle in the app preferences

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, collection set to end May, 2022

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, User Interaction Data

5. Is the data collection request for default-on or default-off?

Default-on

6. Does the instrumentation include the addition of any new identifiers?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result

data-review+

This pull request has conflicts when rebasing. Could you fix it @jonalmeida? 🙏

Intermittent test failing from mockk. I'll fix this in a separate PR and restart the build here until then:

AddonsManagementViewTest. onAddonItemClicked shows details if addon is not installed
io.mockk.MockKException: Can't instantiate proxy for class kotlin.Function1
	at io.mockk.impl.instantiation.JvmMockFactory.newProxy(JvmMockFactory.kt:64)
	at io.mockk.impl.instantiation.AbstractMockFactory.newProxy$default(AbstractMockFactory.kt:29)
	at io.mockk.impl.instantiation.AbstractMockFactory.mockk(AbstractMockFactory.kt:59)
	at io.mockk.impl.annotations.JvmMockInitializer.assignRelaxedMockK(JvmMockInitializer.kt:142)
	at io.mockk.impl.annotations.JvmMockInitializer.initMock(JvmMockInitializer.kt:47)